🌱 Stop setting and relying on TypeMeta in typed objects #12533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
sbueringer
changed the title
|
Pausing the work on this for now, will get back to it in a bit |
k8s-ci-robot
added
the
needs-rebase
sbueringer
force-pushed
the
pr-stop-setting-typemeta
branch
from
9501b0a to
4c6c105
Compare
k8s-ci-robot
added
size/XXL
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-stop-setting-typemeta
branch
from
4c6c105 to
4bbff0b
Compare
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
size/L
sbueringer
force-pushed
the
pr-stop-setting-typemeta
branch
from
4bbff0b to
d3f22da
Compare
k8s-ci-robot
removed
the
needs-rebase
sbueringer
force-pushed
the
pr-stop-setting-typemeta
branch
from
d3f22da to
db6b1d2
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-stop-setting-typemeta
branch
from
db6b1d2 to
2a010f0
Compare
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b2127c196e1df804751dd13529d14d09a8a027ac
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
controller-runtime and k8s.io/* generally don't set TypeMeta on typed objects. So we should stop relying on it being set. Accordingly we should also not set it on typed objects in tests.
This PR mostly focuses on unit tests. There will be another PR with modifications to prod code.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #